Commit 8fcc7f46 authored by Médéric Boquien's avatar Médéric Boquien
Browse files

Properly take into account filters defined in photons.

parent c90428d5
......@@ -12,6 +12,7 @@
### Fixed
- When the pcigale.ini file was missing, pcigale would crash and display a fairly cryptic backtrace. Now it explicitly states that the file could not be found. (Médéric Boquien)
- The nebular emission now takes into account deviations from the 10000K case B assumption. In practice this yields fluxes about 10% fainter. (Médéric Boquien & Akio Inoue)
- Some filters were incorrectly assumed to be defined in units of energy when they were actually defined in units of photons, yielding slightly incorrect fluxes. Now all the filters are converted into units of energy when imported. (Médéric Boquien)
### Optimised
- By default the MKL library created many threads for each for the parallel processes. Not only was this not necessary as a high-level parallelisation already exists, but it generated a strong oversubscription on the CPU and on the RAM. The slowdown was over a factor of ~2 in some cases. Now we mandate KML to use only 1 thread fo each process. (Médéric Boquien & Yannick Roehlly)
......@@ -37,6 +37,10 @@ class Filter(object):
self.trans_table = trans_table
self.effective_wavelength = effective_wavelength
if self.trans_type == 'photon':
self.trans_table[1] *= self.trans_table[0]
self.trans_type = 'energy'
# Check that the trans_type is correct
def trans_type(self):
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment