The absorption of the Lyman continuum from old stars tended to be...

The absorption of the Lyman continuum from old stars tended to be overestimated leading to some “negative fluxes” for the Lyman continuum.

CHANGELOG.md

@@ -31,6 +31,7 @@
 - The order of the parameters for the analysis modules would change each time a new pcigale.ini was generated. Now the order is fixed. (Médéric Boquien)
 - In the output the sfh.age parameter would correspond to the input value minus 1. Now both values are consistent with one another. (Laure Ciesla & Médéric Boquien) 
 - In rare circumstances requiring a specific distribution of redshifts the integration of the spectrum in some filters was not done correctly, inducing relative errors of ~10¯⁵-10¯⁶. (Médéric Boquien)
+- The absorption of the Lyman continuum from old stars tended to be overestimated leading to some “negative fluxes” for the Lyman continuum. (Médéric Boquien)
 
 ### Optimised
 - Prior to version 0.7.0, we needed to maintain the list of redshifts for all the computed models. Past 0.7.0 we just infer the redshift from a list unique redshifts. This means that we can now discard the list of redshifts for all the models and only keep the list of unique redshifts. This saves ~8 MB of memory for every 10⁶ models. the models should be computed slightly faster but it is in the measurement noise. (Médéric Boquien)

pcigale/sed_modules/nebular.py

@@ -136,11 +136,10 @@ class NebularEmission(SedModule):
             self.absorbed_old = np.zeros(sed.wavelength_grid.size)
             self.absorbed_young = np.zeros(sed.wavelength_grid.size)
 
-        self.absorbed_young = np.zeros(sed.wavelength_grid.size)
-        self.absorbed_old[:self.idx_Ly_break] -= (
+        self.absorbed_old[:self.idx_Ly_break] = -(
             sed.get_lumin_contribution('stellar.old')[:self.idx_Ly_break] *
             (1. - self.fesc))
-        self.absorbed_young[:self.idx_Ly_break] -= (
+        self.absorbed_young[:self.idx_Ly_break] = -(
             sed.get_lumin_contribution('stellar.young')[:self.idx_Ly_break] *
             (1. - self.fesc))