From d8fab1dfb0819b8b43fb025c3b2dc85670e10364 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A9d=C3=A9ric=20Boquien?= Date: Mon, 7 Dec 2015 11:56:22 -0300 Subject: [PATCH] The detection of the '_log' suffix in variables and its removal to compute the models was overzealous. Fix this. --- CHANGELOG.md | 6 ++++-- pcigale/analysis_modules/pdf_analysis/__init__.py | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a5eed07..4ce4cf9e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,12 +2,14 @@ ## Unreleased ### Added -- When using the savefluxes module, all the output parameters were saved. This is not efficient when the user is only interested in some of the output parameters but not all. We introduce the "variables" configuration parameter for savefluxes to list the output parameters the user wants to save. If the list is left empty, all parameters are saved, preserving the current behaviour. This should increase the speed substantially when saving memory. +- When using the savefluxes module, all the output parameters were saved. This is not efficient when the user is only interested in some of the output parameters but not all. We introduce the "variables" configuration parameter for savefluxes to list the output parameters the user wants to save. If the list is left empty, all parameters are saved, preserving the current behaviour. This should increase the speed substantially when saving memory. (Médéric Boquien) ### Changed ### Fixed +- To estimate parameters in log, pcigale determines which variables end with the "_log" string and removed it to compute the models. However in some circumstances, it was overzealous. This has been fixed. (Médéric Boquien) + ### Optimised -- Prior to version 0.7.0, we needed to maintain the list of redshifts for all the computed models. Past 0.7.0 we just infer the redshift from a list unique redshifts. This means that we can now discard the list of redshifts for all the models and only keep the list of unique redshifts. This saves ~8 MB of memory for every 10⁶ models. the models should be computed slightly faster but it is in the measurement noise. +- Prior to version 0.7.0, we needed to maintain the list of redshifts for all the computed models. Past 0.7.0 we just infer the redshift from a list unique redshifts. This means that we can now discard the list of redshifts for all the models and only keep the list of unique redshifts. This saves ~8 MB of memory for every 10⁶ models. the models should be computed slightly faster but it is in the measurement noise. (Médéric Boquien) ## 0.8.0 (2015-12-01) ### Added diff --git a/pcigale/analysis_modules/pdf_analysis/__init__.py b/pcigale/analysis_modules/pdf_analysis/__init__.py index eec451c2..936c56e0 100644 --- a/pcigale/analysis_modules/pdf_analysis/__init__.py +++ b/pcigale/analysis_modules/pdf_analysis/__init__.py @@ -126,8 +126,8 @@ class PdfAnalysis(AnalysisModule): # Initalise variables from input arguments. analysed_variables = config["analysed_variables"] - analysed_variables_nolog = [variable.rstrip('_log') for variable in - analysed_variables] + analysed_variables_nolog = [''.join(variable.rsplit('_log', 1)) for + variable in analysed_variables] n_variables = len(analysed_variables) save = {key: config["save_{}".format(key)].lower() == "true" for key in ["best_sed", "chi2", "pdf"]} -- GitLab