GitLab

Guang authored Jun 20, 2019 and Guang committed Oct 23, 2019

modify skirtor from anisotorpic to isotropic; add polar dust for skirtor; connect xray with skirtor; bug fixed for fritz

The name creation_modules is a bit vague. For more clarity and consistency we rather use sed_modules now

Specify the types and the constraints of the input parameters for the SED creation modules and the analysis modules. Once validation is activated, the validation module will be able to infer the constraints from the specified information.

Modules were a bit inconsistent how the input parameters are used. It was not always ensured they were the right type, they were sometimes read several times, and finally they were not always obtained from the _init_code() method. This is an attempt to clean that up as much as possible.

Simplify the construction of modules by remove the out_parameter_list dictionary. It was not used anywhere, was not always provided, and was not even up to date.

Switch back to ordered dictionaries for the input parameters after all. That way the list of parameters is kept into a logical order when building the configuration file. The impact on performance is negligible.

We rely on OrderedDict to keep the order of the parameters. However given the way the code is structured currently, there is really no reason for this. So let's just switch to the standard dictionary. This has two advantages. First the standard dictionary is much faster than OrderedDict (implemented in C rather than in pure python). Then, standard dictionaries are marshalable, which makes them usable as keys for other dictionaries.

To verify whether a variable is among the keys of a dictionary there is actually no need to call the keys() function. A dictionary has a __contains__() member which is called when the “in” keyword is used.

Last (?) modification of the Fritz 2006 parameters. The opening angle is in agreement with Fig. 1 in Fritz (2006). The viewing angle is in agreement with Hatziminaoglou (2008) and Fritz (2010) models.

Given the current formula, an AGN fraction of 1 would yield an infinite luminosity. We are clearly out of the accepted bounds for the model. So rather than ruining the fits, we rather raise an Exception and terminate.