GitLab

Guang authored Feb 03, 2019 and Guang committed Oct 23, 2019

1. remove "weight"
2. allow for short wavelength (<912 A)
3. remove ad hoc "X-ray wavelength"

The computation of all the cosmology-dependent quantities has been consolidated in pcigale/utils/cosmology.py and optimised. This leads to a slightly faster startup, in particular when there are many objects to fit, and it makes it easier to change the cosmology.

Clarify a bit the description of the redshifting module as we do not always just fit a single galaxy

Import factorial from scipy.special rather than scipy.misc as importing from the latter is deprecated since Scipy 1.0.0.

When calling np.sum(), the axis should be an integer, not a float, otherwise it triggers a very disgracious Numpy warning. Now it is gone.

Computers are much better at multiplying than at dividing. Therefore to correct the emission for redshifting we multiply by 1/(1+z) rather than dividing by 1+z.

The name creation_modules is a bit vague. For more clarity and consistency we rather use sed_modules now

Specify the types and the constraints of the input parameters for the SED creation modules and the analysis modules. Once validation is activated, the validation module will be able to infer the constraints from the specified information.

Modules were a bit inconsistent how the input parameters are used. It was not always ensured they were the right type, they were sometimes read several times, and finally they were not always obtained from the _init_code() method. This is an attempt to clean that up as much as possible.

We rely on OrderedDict to keep the order of the parameters. However given the way the code is structured currently, there is really no reason for this. So let's just switch to the standard dictionary. This has two advantages. First the standard dictionary is much faster than OrderedDict (implemented in C rather than in pure python). Then, standard dictionaries are marshalable, which makes them usable as keys for other dictionaries.

To verify whether a variable is among the keys of a dictionary there is actually no need to call the keys() function. A dictionary has a __contains__() member which is called when the “in” keyword is used.

Now that we handle the luminosity and the individual component separately for speed reasons, we must not forget to scale the total luminosity appropriately when redshifting. Otherwise the fluxes in the filters will be overestimated by a factor 1+z.

Now that we do not add an AGN component anymore when the AGN fraction is 0, the wavelength grid may change from one model to the other. To work around this issue we save the IGM component into a dictionary with the key being the size of the grid. This is not completely foolproof as two grids of same length may have different wavelengths, though that is quite unlikely given pcigale's architecture. It should be good enough for now.

This reverts commit c160b8f8.

Make model computations much faster. On a test run we spent 20% of the time just computing the luminosity distance. Now the information is just provided by the redshifting module. If the information is not present we just assume a distance of 10 pc.

If there is no redshift information, we assumed that the redshift is 0. Also correct a bogus test in the redshifting module.

Make pdf_analysis parallel. This required important changes. Functions saving data have been moved to the utils.py file. Workers for the parallel processes have been put in workers.py. To make sure we eliminate models incompatible with the age of the universe now the latter is indicated in sed.info for easy access. Ditto for the redshift.

Change the way redshifts are handled. Now all redshifts are specified in pcigale.ini. To compute the χ², we simply take the models corresponding to the closest χ².