Merge branch '6-add-tests-for-instance-shared-search-module' into 'develop'

Fix SQ smelly code

Closes #6

See merge request !23

client/src/app/instance/search/components/result/download.component.ts

@@ -41,7 +41,7 @@ export class DownloadComponent {
      * @return boolean
      */
     isDownloadActivated(): boolean {
-        const dataset = this.datasetList.find(dataset => dataset.name === this.datasetSelected);
+        const dataset = this.datasetList.find(d => d.name === this.datasetSelected);
         return dataset.config.download.download_enabled;
     }
 
@@ -51,7 +51,7 @@ export class DownloadComponent {
      * @return boolean
      */
     isDownloadOpened(): boolean {
-        const dataset = this.datasetList.find(dataset => dataset.name === this.datasetSelected);
+        const dataset = this.datasetList.find(d => d.name === this.datasetSelected);
         return dataset.config.download.download_opened;
     }
 

client/src/app/instance/search/components/result/reminder.component.ts

@@ -38,7 +38,7 @@ export class ReminderComponent {
      * @return boolean
      */
     isSummaryActivated(): boolean {
-        const dataset = this.datasetList.find(dataset => dataset.name === this.datasetSelected);
+        const dataset = this.datasetList.find(d => d.name === this.datasetSelected);
         return dataset.config.summary.summary_enabled;
     }
 
@@ -48,7 +48,7 @@ export class ReminderComponent {
      * @return boolean
      */
     isSummaryOpened(): boolean {
-        const dataset = this.datasetList.find(dataset => dataset.name === this.datasetSelected);
+        const dataset = this.datasetList.find(d => d.name === this.datasetSelected);
         return dataset.config.summary.summary_opened;
     }
 

client/src/app/instance/search/components/result/samp.component.ts

@@ -33,7 +33,7 @@ export class SampComponent {
      * @return boolean
      */
     isSampActivated(): boolean {
-        const dataset = this.datasetList.find(dataset => dataset.name === this.datasetSelected);
+        const dataset = this.datasetList.find(d => d.name === this.datasetSelected);
         return dataset.config.samp.samp_enabled;
     }
 
@@ -43,7 +43,7 @@ export class SampComponent {
      * @return boolean
      */
     isSampOpened(): boolean {
-        const dataset = this.datasetList.find(dataset => dataset.name === this.datasetSelected);
+        const dataset = this.datasetList.find(d => d.name === this.datasetSelected);
         return dataset.config.samp.samp_opened;
     }
 

client/src/app/instance/shared-search/components/datatable/datatable.component.ts

@@ -85,7 +85,7 @@ export class DatatableComponent implements OnInit {
                 config = attribute.renderer_config as ImageRendererConfig;
                 break;
             case 'json':
-                config = attribute.renderer_config as RendererConfig;
+                config = attribute.renderer_config;
                 break;
             default:
                 config = null;

client/src/app/metamodel/models/column.model.ts

@@ -10,4 +10,4 @@
 export interface Column {
     name: string;
     type: string;
-};
+}